Disabled preloading when switching streams#4246
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Sep 25, 2020
Merged
Conversation
5 tasks
TobiGr
approved these changes
Sep 25, 2020
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Thanks!
This PR does not only save data, but also speeds up switching streams 👍
Stypox
approved these changes
Sep 25, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Looks good to me, too, and by the test I made it works :-D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
When you play one video and then select another the player will stop loading the first stream. Which theoretically saves some megabytes while next video is loading. So the first video will NOT stop playing but will stop loading more parts that will never be viewed because the second video shows up.
Fixes the following issue(s)
closes #4232
Testing apk
disabled-preloading.zip
Agreement